[libcamera-devel] [PATCH] ipa: ipu3: af: Set default grid block width to the minimum value

Kate Hsuan hpa at redhat.com
Tue Mar 22 02:31:19 CET 2022


Since x	coordinate is incorrectly computed by a kernel issue, the block width
should be set to 4 to prevent using the second stripe when setting the AF scene
to the centre of the image. A kernel patch had fixed this issue. Therefore, this
value can be set to the default minimum value.

Signed-off-by: Kate Hsuan <hpa at redhat.com>
---
The kernel patch is shown as following URL.
https://lore.kernel.org/linux-media/CAEth8oES8abPO4p7eFv43PwDXuxeOmg1661YtVvykBPrkagzKg@mail.gmail.com/T/#mb02fa73ce9e3089a4619c318badb2047a3ac39e2
---
 src/ipa/ipu3/algorithms/af.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h
index 13c7e0e8..108fcd18 100644
--- a/src/ipa/ipu3/algorithms/af.h
+++ b/src/ipa/ipu3/algorithms/af.h
@@ -20,7 +20,7 @@ static constexpr uint8_t kAfMinGridWidth = 16;
 static constexpr uint8_t kAfMinGridHeight = 16;
 static constexpr uint8_t kAfMaxGridWidth = 32;
 static constexpr uint8_t kAfMaxGridHeight = 24;
-static constexpr uint16_t kAfMinGridBlockWidth = 4;
+static constexpr uint16_t kAfMinGridBlockWidth = 3;
 static constexpr uint16_t kAfMinGridBlockHeight = 3;
 static constexpr uint16_t kAfMaxGridBlockWidth = 6;
 static constexpr uint16_t kAfMaxGridBlockHeight = 6;
-- 
2.33.1



More information about the libcamera-devel mailing list