[libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper: Make exposure conversion functions virtual

[Laurent Pinchart]

On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:
> Quoting Laurent Pinchart (2021-12-19 23:27:12)
> > From: Naushir Patuck <naush at raspberrypi.com>
> > 
> > Some sensors (namely the Sony IMX296, whose support will be added
> > shortly) require different conversion formulas between exposure time and
> > exposure lines. Make the Exposure() and ExposureLines() functions
> > virtual to allow this.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Naush, could I get your SoB line for this patch ?

> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  src/ipa/raspberrypi/cam_helper.hpp | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp
> > index a776153fcb84..300f8f8a2d3b 100644
> > --- a/src/ipa/raspberrypi/cam_helper.hpp
> > +++ b/src/ipa/raspberrypi/cam_helper.hpp
> > @@ -76,8 +76,8 @@ public:
> >         virtual void Prepare(libcamera::Span<const uint8_t> buffer,
> >                              Metadata &metadata);
> >         virtual void Process(StatisticsPtr &stats, Metadata &metadata);
> > -       uint32_t ExposureLines(libcamera::utils::Duration exposure) const;
> > -       libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;
> > +       virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;
> > +       virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;
> >         virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,
> >                                       libcamera::utils::Duration minFrameDuration,
> >                                       libcamera::utils::Duration maxFrameDuration) const;

-- 
Regards,

Laurent Pinchart