[libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV5640 sensor properties

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Mar 23 01:42:00 CET 2022


Hi Paul,

Thank you for the patch.

On Wed, Mar 16, 2022 at 05:16:58PM +0900, Paul Elder via libcamera-devel wrote:
> Add an entry to the sensor properties for the ov5640. Only the first
> test pattern is included as the others that are exposed by the kernel
> don't correspond to any that are defined in the libcamera control.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 48305ac4..027d74e1 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				{ controls::draft::TestPatternModePn9, 4 },
>  			},
>  		} },
> +		{ "ov5640", {
> +			.unitCellSize = { 1400, 1400 },
> +			.testPatternModes = {
> +				{ controls::draft::TestPatternModeOff, 0 },
> +				{ controls::draft::TestPatternModeColorBars, 1 },
> +			},
> +		} },
>  		{ "ov5647", {
>  			.unitCellSize = { 1400, 1400 },
>  			.testPatternModes = {},

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list