[libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290 sensor properties

[Laurent Pinchart]

Hi Kieran,

On Mon, Mar 28, 2022 at 02:32:41PM +0100, Kieran Bingham wrote:
> Quoting Jacopo Mondi via libcamera-devel (2022-03-28 13:56:38)
> > On Mon, Mar 28, 2022 at 02:56:42PM +0300, Laurent Pinchart via libcamera-devel wrote:
> > > The Sony IMX290 is a rolling shutter sensor with a 1945x1109 pixel array
> > > size, with a recommended resolution after CFA interpolation of
> > > 1920x1080.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > 
> > I don't have a datasheet so I trust your calculations
> > 
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> > 
> > > ---
> > >  src/libcamera/camera_sensor_properties.cpp | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> > > index 80a0bbac8901..7a3490125e11 100644
> > > --- a/src/libcamera/camera_sensor_properties.cpp
> > > +++ b/src/libcamera/camera_sensor_properties.cpp
> > > @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
> > >                               { controls::draft::TestPatternModePn9, 4 },
> > >                       },
> > >               } },
> > > +             { "imx290", {
> > > +                     .unitCellSize = { 2900, 2900 },
> 
> Matches the values reported in 
> https://www.sony-semicon.co.jp/products/common/pdf/IMX226CLJ_CQJ_Flyer.pdf
> 
> Interestingly it also says: 
> 
> > "Number of effective pixels: 1945 (H) × 1097 (V)"
> 
> Which I guess is the 1109 - some vertical blanking. But I haven't see
> those values yet. Perhaps they're hidden in more complete datasheets
> that I don't have access to.

There are also 10 rows of usable optical blank, and 2 rows of ignored
optical blank.

> But I don't see any reason to doubt this otherwise so:
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > > +                     .testPatternModes = {},
> > > +             } },
> > >               { "imx296", {
> > >                       .unitCellSize = { 3450, 3450 },
> > >                       .testPatternModes = {},

-- 
Regards,

Laurent Pinchart