[libcamera-devel] [PATCH v3 0/5] ipa: ipu3: af: Small improvements

[Jean-Michel Hautbois]

Hi Kieran,

On 25/03/2022 10:25, Kieran Bingham wrote:
> Following review of the IPU3 Af implementation, the following additional
> improvements were identified.
> 
> No functional change to the running of the algorithm is intended or
> expected, though this does remove a memcpy, and adapts to use a Span for
> range based iterators, as well as hopefully make it easier to use custom
> ROI's and return the AF regions in later developments.
> 
>   *** This is only compile tested! ***
> 
> Kate/JM - could you test this please?

For my side:
Tested-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> 
> v3:
>   - Minor cleanups from Laurent and collect tags.
>   - Keeping the two loop implementation of Af::afEstimateVariance
>     to prevent risk of "catasrophic cancellation".
> 
> Kieran Bingham (5):
>    ipa: ipu3: af: Move constants to implementation
>    ipa: ipu3: af: Use geometry classes to perform grid centering
>    ipa: ipu3: af: Remove redundant memcpy
>    ipa: ipu3: af: Use Span for y_table_item_t
>    ipa: ipu3: af: Simplify accumulations of y_items
> 
>   src/ipa/ipu3/algorithms/af.cpp | 140 +++++++++++++--------------------
>   src/ipa/ipu3/algorithms/af.h   |  15 +---
>   2 files changed, 56 insertions(+), 99 deletions(-)
>