[libcamera-devel] [PATCH v3 5/5] ipa: ipu3: af: Simplify accumulations of y_items

[Jean-Michel Hautbois]

Hi Kieran,

Thanks for the patch !

On 25/03/2022 10:25, Kieran Bingham wrote:
> Simplify the accumulation of the total and variance with a ternary
> operator.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>

> ---
>   src/ipa/ipu3/algorithms/af.cpp | 14 ++++----------
>   1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp
> index c0f2d34368cb..6c25d02ec7f0 100644
> --- a/src/ipa/ipu3/algorithms/af.cpp
> +++ b/src/ipa/ipu3/algorithms/af.cpp
> @@ -341,20 +341,14 @@ double Af::afEstimateVariance(Span<const y_table_item_t> y_items, bool isY1)
>   	double mean;
>   	double var_sum = 0;
>   
> -	for (auto y : y_items) {
> -		if (isY1)
> -			total += y.y1_avg;
> -		else
> -			total += y.y2_avg;
> -	}
> +	for (auto y : y_items)
> +		total += isY1 ? y.y1_avg : y.y2_avg;
>   
>   	mean = total / y_items.size();
>   
>   	for (auto y : y_items) {
> -		if (isY1)
> -			var_sum += pow(y.y1_avg - mean, 2);
> -		else
> -			var_sum += pow(y.y2_avg - mean, 2);
> +		double avg = isY1 ? y.y1_avg : y.y2_avg;
> +		var_sum += pow(avg - mean, 2);
>   	}
>   
>   	return var_sum / y_items.size();