[libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add OV5640 helper

[paul.elder at ideasonboard.com]

On Mon, Mar 28, 2022 at 04:40:56PM +0300, Laurent Pinchart wrote:
> On Mon, Mar 28, 2022 at 02:21:33PM +0100, Kieran Bingham wrote:
> > Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04)
> > > From: Paul Elder <paul.elder at ideasonboard.com>
> > 
> > Missing SoB.
> 
> Oops. Paul, could you please reply with your SoB line ?

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

> 
> > > The OV5640 is am OmniVision sensor with a linear gain model, expressed
> > > in 1/16 steps.
> > 
> > /am/an/
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > > ---
> > >  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> > > index 0ec51f4e0753..c098e48cdfe0 100644
> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp
> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> > > @@ -407,6 +407,17 @@ public:
> > >  };
> > >  REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740)
> > >  
> > > +class CameraSensorHelperOv5640 : public CameraSensorHelper
> > > +{
> > > +public:
> > > +       CameraSensorHelperOv5640()
> > > +       {
> > > +               gainType_ = AnalogueGainLinear;
> > > +               gainConstants_.linear = { 1, 0, 0, 16 };
> > > +       }
> > > +};
> > > +REGISTER_CAMERA_SENSOR_HELPER("ov5640", CameraSensorHelperOv5640)
> > > +
> > >  class CameraSensorHelperOv5670 : public CameraSensorHelper
> > >  {
> > >  public:
> 
> -- 
> Regards,
> 
> Laurent Pinchart