[libcamera-devel] [PATCH 2/3] Documentation: fix typos

Jacopo Mondi jacopo at jmondi.org
Wed May 4 12:13:55 CEST 2022


On Wed, May 04, 2022 at 11:56:22AM +0200, Quentin Schulz wrote:
> Hi Kieran,
>
> On 5/4/22 11:42, Kieran Bingham via libcamera-devel wrote:
> > Quoting Jacopo Mondi via libcamera-devel (2022-05-04 08:11:42)
> > > Hi Quentin
> > >
> > > On Tue, May 03, 2022 at 06:30:37PM +0200, Quentin Schulz via libcamera-devel wrote:
> > > > From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> > > >
> > > > A few typos made it to the docs, so let's fix them.
> > > >
> > > > Cc: Quentin Schulz <foss+libcamera at 0leil.net>
> > > > Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> > > > ---
> [...]
> > > >   ``V4LPixelFormat`` and ``SizeRange`` supported by the underlying output device,
> > > >   but the pipeline handler needs to convert this to a ``libcamera::PixelFormat``
> > > >   type to pass to applications. We do this here using ``std::transform`` to
> > > > @@ -811,9 +811,9 @@ Continue adding the following code to support this:
> > > >      StreamConfiguration cfg(formats);
> > > >
> > > >   As well as a list of supported StreamFormats, the StreamConfiguration is also
> > > > -expected to provide an initialised default configuration. This may be arbitrary,
> > > > -but depending on use case you may which to select an output that matches the
> > > > -Sensor output, or prefer a pixelformat which might provide higher performance on
> > > > +expected to provide an initialised default configuration. This may be arbitrary,
> > >
> > > ack
> >
> > I can't actually see any change in that line which is added here?
> >
>
> Mmmm. Don't know what Jacopo did to the git diff but the patch has the typo
> in the original file :)

Ups my bad

To verify documentation changes like this one I simply search in vi
for the whole phrase, typing it it until one of the two lines differ.

I might have changed the first part to check if anything else had been
modified, sorry

>
> s/initialsed/initialised/
>
> s/which/wish/
>
> Cheers,
> Quentin


More information about the libcamera-devel mailing list