[libcamera-devel] [PATCH v7 03/13] meson: add 'check: true' for run_command() calls

[Tomi Valkeinen]

On 05/05/2022 15:33, Kieran Bingham wrote:
> Quoting Tomi Valkeinen (2022-05-05 11:40:54)
>> Add 'check: true' to all run_command() calls as suggested in
>> https://github.com/mesonbuild/meson/issues/9300 to get rid of meson
>> warning "You should add the boolean check kwarg to the run_command
>> call."
>>
>> This makes meson fail if the executed command fails, which makes sense.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>> ---
>>   meson.build | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 10ad8c5c..0124e7d3 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -18,7 +18,8 @@ project('libcamera', 'c', 'cpp',
>>   # libcamera_git_version.
>>   libcamera_git_version = run_command('utils/gen-version.sh',
>>                                       meson.project_build_root(),
>> -                                    meson.project_source_root()).stdout().strip()
>> +                                    meson.project_source_root(),
>> +                                    check: true).stdout().strip()
>>   if libcamera_git_version == ''
> 
> I think I recall on ChromeOS builds - there was something about the
> build occuring in a different tree location - and it affected this
> somehow.
> 
> So ... I would say 'Yes, I agree with this change' - but it will need
> specific testing to make sure we don't break chrome builds.
> 
> (That's part of my integration tests anyway, but just highlighting here)
> 
> So assuming we don't break a build :
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Thanks! Btw, feel free to pick these three first patches separately if 
they look fine.

  Tomi