[libcamera-devel] [PATCH] ipa: raspberrypi: Demote noisy message to Debug

Naushir Patuck naush at raspberrypi.com
Mon May 9 09:22:10 CEST 2022


Hi Laurent,

Thank you for your patch.

On Sat, 7 May 2022 at 14:30, Laurent Pinchart <
laurent.pinchart at ideasonboard.com> wrote:

> The message that prints all controls in a request in
> IPARPi::queueRequest() is noisy. Demote it from Info to Debug.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>

Reviewed-by: Naushir Patuck <naush at raspberrypi.com>


> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp
> b/src/ipa/raspberrypi/raspberrypi.cpp
> index 5efd051bdd13..05dc626aa90b 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls)
>         libcameraMetadata_.clear();
>
>         for (auto const &ctrl : controls) {
> -               LOG(IPARPI, Info) << "Request ctrl: "
> -                                 << controls::controls.at
> (ctrl.first)->name()
> -                                 << " = " << ctrl.second.toString();
> +               LOG(IPARPI, Debug) << "Request ctrl: "
> +                                  << controls::controls.at
> (ctrl.first)->name()
> +                                  << " = " << ctrl.second.toString();
>
>                 switch (ctrl.first) {
>                 case controls::AE_ENABLE: {
>
> base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925
> --
> Regards,
>
> Laurent Pinchart
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220509/864ce8b3/attachment.htm>


More information about the libcamera-devel mailing list