[libcamera-devel] [PATCH v3 0/2] Application support for per-mode sensitivities

[Jacopo Mondi]

Hi Naush, Kieran,

On Tue, May 10, 2022 at 08:59:35AM +0100, Naushir Patuck via libcamera-devel wrote:
> Hi,
>
> On Thu, 21 Apr 2022 at 16:11, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> > Hi,
> >
> > This is a continuation of David's work.  As per the discussion on the v2
> > patch
> > set, I've changed things around to use the camera properties to pass out
> > the
> > sensitivities to the application instead of a new field in
> > CameraConfiguration.
> >
> > I've also removed all R-B tags to allow a fresh review.
> >
> > Regards,
> > Naush
> >
> > David Plowman (1):
> >   libcamera: raspberrypi: Fetch correct value for SensorSensitivity
> >
> > Naushir Patuck (1):
> >   libcamera: Add a SensorSensitivity property
> >
> >  include/libcamera/ipa/raspberrypi.mojom            |  7 ++++++-
> >  src/ipa/raspberrypi/raspberrypi.cpp                |  7 +++++--
> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++++----
> >  src/libcamera/property_ids.yaml                    | 12 ++++++++++++
> >  4 files changed, 31 insertions(+), 7 deletions(-)
> >
>
> Gentle ping.  This series needs one more R-B tag.

I haven't followed the discussion in detail, but the patches look sane

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
   j

>
> Regards,
> Naush
>
>
> >
> > --
> > 2.25.1
> >
> >