[libcamera-devel] [PATCH 10/50] staging: media: imx: imx7-media-csi: Remove imx_media_of_add_csi
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue May 10 13:51:07 CEST 2022
From: Paul Elder <paul.elder at ideasonboard.com>
imx_media_of_add_csi() from imx-media-of.c validates that the fwnode for
the CSI bridge is enabled, and adds the fwnode to the async notifier of
the imxmd. The former is redundant, as if the CSI bridge driver probes,
clearly it is enabled in the DT. The latter is not needed as the imxmd
notifier isn't used anymore. The call is thus not needed and can be
dropped. This removes the dependency of imx7-media-csi.c on
imx-media-of.c.
Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
drivers/staging/media/imx/imx7-media-csi.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index d85b5ab204df..e7dcb602afae 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -1203,12 +1203,6 @@ static int imx7_csi_media_init(struct imx7_csi *csi)
if (IS_ERR(imxmd))
return PTR_ERR(imxmd);
- ret = imx_media_of_add_csi(imxmd, csi->dev->of_node);
- if (ret < 0 && ret != -ENODEV && ret != -EEXIST) {
- imx7_csi_media_cleanup(csi);
- return ret;
- }
-
csi->imxmd = imxmd;
v4l2_subdev_init(&csi->sd, &imx7_csi_subdev_ops);
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list