[libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add OV5675 sensor properties

[Kieran Bingham]

Quoting Quentin Schulz via libcamera-devel (2022-05-03 16:57:24)
> From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> 
> Add an entry to the sensor properties for OmniVision OV5675. Only the
> first test pattern is included as the others that are exposed by the
> kernel aren't supported by libcamera control yet.
> 
> Cc: Quentin Schulz <foss+libcamera at 0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> ---
>  src/libcamera/camera_sensor_properties.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 7a349012..235edca1 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -123,6 +123,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                                 { controls::draft::TestPatternModeColorBars, 1 },
>                         },
>                 } },
> +               { "ov5675", {
> +                       .unitCellSize = { 1120, 1120 },

Checks out.


> +                       .testPatternModes = {
> +                               { controls::draft::TestPatternModeOff, 0 },
> +                               { controls::draft::TestPatternModeColorBars, 1 },

Looks reasonable to start.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> +                       },
> +               } },
>                 { "ov5693", {
>                         .unitCellSize = { 1400, 1400 },
>                         .testPatternModes = {
> -- 
> 2.35.1
>