[libcamera-devel] [PATCH 04/14] py: unittests: fix selector fd use

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Mon, May 16, 2022 at 05:10:12PM +0300, Tomi Valkeinen wrote:
> pyright complains about passing fileobj to os.read. Indeed, the
> parameter should be an int, but I guess fileobj gets automatically
> converted. In any case, using the fd is better.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  test/py/unittests.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/py/unittests.py b/test/py/unittests.py
> index cbc00ff3..9326358d 100755
> --- a/test/py/unittests.py
> +++ b/test/py/unittests.py
> @@ -262,8 +262,8 @@ class SimpleCaptureMethods(CameraTesterBase):
>          running = True
>          while running:
>              events = sel.select()
> -            for key, mask in events:
> -                os.read(key.fileobj, 8)
> +            for key, _ in events:
> +                os.read(key.fd, 8)
>  
>                  ready_reqs = cm.get_ready_requests()
>  

-- 
Regards,

Laurent Pinchart