[libcamera-devel] [PATCH 05/14] py: unittests: verify that cam and cm are freed

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Mon, May 16, 2022 at 05:10:13PM +0300, Tomi Valkeinen wrote:
> Add checks to CameraTesterBase to verify that both the Camera and the
> CameraManager gets freed.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
> ---
>  test/py/unittests.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/test/py/unittests.py b/test/py/unittests.py
> index 9326358d..288dcd48 100755
> --- a/test/py/unittests.py
> +++ b/test/py/unittests.py
> @@ -83,6 +83,10 @@ class CameraTesterBase(BaseTestCase):
>              self.cm = None
>              raise Exception('Failed to acquire camera')
>  
> +        self.wr_cam = weakref.ref(self.cam)
> +        self.wr_cm = weakref.ref(self.cm)
> +
> +

Extra blank line ? Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>      def tearDown(self):
>          # If a test fails, the camera may be in running state. So always stop.
>          self.cam.stop()
> @@ -94,6 +98,9 @@ class CameraTesterBase(BaseTestCase):
>          self.cam = None
>          self.cm = None
>  
> +        self.assertIsNone(self.wr_cm())
> +        self.assertIsNone(self.wr_cam())
> +
>  
>  class AllocatorTestMethods(CameraTesterBase):
>      def test_allocator(self):

-- 
Regards,

Laurent Pinchart