[libcamera-devel] [PATCH 00/14] Misc Python bindings patches
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue May 17 10:45:47 CEST 2022
Hi Tomi,
Thank you for the series.
On Mon, May 16, 2022 at 06:48:02PM +0300, Tomi Valkeinen wrote:
> On 16/05/2022 17:10, Tomi Valkeinen wrote:
> > Hi,
> >
> > Smallish Python bindings patches doing cleanups, fixes and a few small
> > features.
>
> This seems to be missing meson changes to install the new files. I'll
> add that to v2.
The series looks quite good overall. If more discussions are needed for
patch 08/14, could you move it and 09/14 to the end of the series in v2
so that the rest can be merged already ?
> > Tomi Valkeinen (14):
> > py: meson: fix comment about stubs
> > py: meson: add pystubs build target
> > py: pymain: fix indent
> > py: unittests: fix selector fd use
> > py: unittests: verify that cam and cm are freed
> > py: unittests: make typechecker happy
> > py: cam.py: exit on exception
> > py: move conversion funcs to libcamera.utils
> > py: conv.py: minor cleanups
> > py: implement PixelFormat class
> > py: add geometry classes
> > py: use geometry classes
> > py: cam_kms: support multiplanar formats
> > py: cam_kms: fix multistream display
> >
> > src/py/cam/cam.py | 34 +++--
> > src/py/cam/cam_kms.py | 31 ++---
> > src/py/cam/cam_qt.py | 200 +----------------------------
> > src/py/cam/cam_qtgl.py | 20 +--
> > src/py/cam/gl_helpers.py | 8 --
> > src/py/libcamera/meson.build | 22 +++-
> > src/py/libcamera/pygeometry.cpp | 104 +++++++++++++++
> > src/py/libcamera/pymain.cpp | 90 ++++++-------
> > src/py/libcamera/utils/__init__.py | 4 +
> > src/py/libcamera/utils/conv.py | 160 +++++++++++++++++++++++
> > test/py/unittests.py | 28 ++--
> > 11 files changed, 392 insertions(+), 309 deletions(-)
> > create mode 100644 src/py/libcamera/pygeometry.cpp
> > create mode 100644 src/py/libcamera/utils/__init__.py
> > create mode 100644 src/py/libcamera/utils/conv.py
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list