[libcamera-devel] [PATCH] py: Fix link generation to __init__.py

Kieran Bingham kieran.bingham at ideasonboard.com
Tue May 17 19:23:00 CEST 2022


Quoting Laurent Pinchart via libcamera-devel (2022-05-17 18:16:38)
> The command to create a symlink to the __init__.py file in the source
> directory uses a relative path from the build directory, which hardcodes
> the assumption that the build directory is a direct child of the source
> directory. This isn't always true. Fix it by using the files() function.
> 
> Fixes: 8aa02271fd71 ("Add Python bindings")
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/py/libcamera/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
> index 0cd7c75bb86c..2fc2eaec1c82 100644
> --- a/src/py/libcamera/meson.build
> +++ b/src/py/libcamera/meson.build
> @@ -54,7 +54,7 @@ pycamera = shared_module('_libcamera',
>                           dependencies : pycamera_deps,
>                           cpp_args : pycamera_args)
>  
> -run_command('ln', '-fsT', '../../../../src/py/libcamera/__init__.py',
> +run_command('ln', '-fsT', files('__init__.py'),

eep.


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>              meson.current_build_dir() / '__init__.py',
>              check: true)
>  
> 
> base-commit: 5efb6c8e2acdc2dc9edf1f22f6c2a5818062b69e
> -- 
> Regards,
> 
> Laurent Pinchart
>


More information about the libcamera-devel mailing list