[libcamera-devel] [PATCH v4 0/4] generate and use fixed-sized Span Control types

[Christian Rauch]

Hi all,

Can you let me know what is missing to go forward with this? I think I
resolved all comments.

Best,
Christian


Am 27.04.22 um 23:30 schrieb Christian Rauch:
> Hello,
>
> In version 4 of this patch set I applied minor modification from feedback that I received so far. I reorderd the commits such that the "std::optional" commit appears first and can be used without the changes related to fixed-sized Spans.
>
> Best,
>
> Christian Rauch (4):
>   use std::optional to handle invalid control values
>   libcamera: controls: Define size of array controls as a shape vector
>   generate fixed- and variable-sized Span Controls
>   apply explicit fixed-sized Span type casts
>
>  include/libcamera/controls.h                  |  7 ++--
>  src/cam/main.cpp                              |  4 +--
>  src/ipa/raspberrypi/raspberrypi.cpp           | 21 ++++++------
>  src/libcamera/control_ids.yaml                |  2 +-
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 +++---
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 10 +++---
>  src/libcamera/property_ids.yaml               |  4 +--
>  src/qcam/dng_writer.cpp                       | 15 +++++----
>  utils/gen-controls.py                         | 32 +++++++++++++------
>  9 files changed, 61 insertions(+), 43 deletions(-)
>
> --
> 2.34.1