[libcamera-devel] [PATCH v2 06/13] py: unittests: make typechecker happy

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Wed May 18 08:51:27 CEST 2022


On 17/05/2022 19:51, Kieran Bingham wrote:
> Quoting Laurent Pinchart (2022-05-17 17:08:25)
>> Hi Tomi,
>>
>> Thank you for the patch.
>>
>> On Tue, May 17, 2022 at 05:33:18PM +0300, Tomi Valkeinen wrote:
>>> Add some annotations and self.assertIsNotNone() calls to remove the
>>> typechecker warnings.
>>>
> 
> Are pyright and typechecker external commands that we need to introduce
> as part of our integration tests to verify commits now?

pyright is the typechecker I use, or my editor uses. I'm not familiar 
with the internals, seems to be some horrible contraption with node.js 
and whatnots...

A Python static typechecker to verify the commits would be nice, 
although at least pyright seems to complain about lots of unnecessary 
things. But I presume adjusting the settings would give us something 
usable. I have to admit I'm pretty clueless about those, though.

  Tomi


More information about the libcamera-devel mailing list