[libcamera-devel] [PATCH v3 10/18] py: cam_kms: fix multistream display
Tomi Valkeinen
tomi.valkeinen at ideasonboard.com
Wed May 18 15:13:21 CEST 2022
Instead of doing an atomic commit for each stream, do a single commit
for the two planes. This fixes the issue that only the first plane was
actually shown.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
src/py/cam/cam_kms.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py
index f1844717..d8ff0284 100644
--- a/src/py/cam/cam_kms.py
+++ b/src/py/cam/cam_kms.py
@@ -75,12 +75,13 @@ class KMSRenderer:
buffers = drmreq['camreq'].buffers
+ req = pykms.AtomicReq(self.card)
+
for stream, fb in buffers.items():
drmfb = self.cam_2_drm.get(fb, None)
-
- req = pykms.AtomicReq(self.card)
self.add_plane(req, stream, drmfb)
- req.commit()
+
+ req.commit()
def handle_page_flip(self, frame, time):
old = self.current
--
2.34.1
More information about the libcamera-devel
mailing list