[libcamera-devel] [PATCH] android: Drop gcc 7 compatibility

Kieran Bingham kieran.bingham at ideasonboard.com
Fri May 20 09:37:35 CEST 2022


Quoting Laurent Pinchart via libcamera-devel (2022-05-19 19:54:04)
> Now that we have dropped gcc 7 support, remove the compatibility with
> gcc versions older than 8 that implemented the filesystem API in the
> std::experimental namespace.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

This sounds good.

Wasn't there some (potential) task blocked about using <filesystem>
because of the android hal, which would now be unblocked?

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/android/camera_hal_config.cpp | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp
> index 29e506ff5e28..28072cb86285 100644
> --- a/src/android/camera_hal_config.cpp
> +++ b/src/android/camera_hal_config.cpp
> @@ -6,14 +6,7 @@
>   */
>  #include "camera_hal_config.h"
>  
> -#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8
> -#include <experimental/filesystem>
> -namespace std {
> -namespace filesystem = std::experimental::filesystem;
> -}
> -#else
>  #include <filesystem>
> -#endif
>  #include <stdlib.h>
>  #include <string>
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>


More information about the libcamera-devel mailing list