[libcamera-devel] [PATCH v2 04/19] py: Fix SceneFlicker enum values

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Tue May 24 13:45:55 CEST 2022


Stripping 'SceneFlicker' prefix from the enum value names leads to
'50Hz' and '60Hz', which are not valid names. So add another heuristics
to keep the prefix for SceneFlicker.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/py/libcamera/gen-py-control-enums.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py
index dcc28b1a..6b2b5362 100755
--- a/src/py/libcamera/gen-py-control-enums.py
+++ b/src/py/libcamera/gen-py-control-enums.py
@@ -42,6 +42,9 @@ def generate_py(controls):
 
         if name == 'LensShadingMapMode':
             prefix = 'LensShadingMapMode'
+        elif name == 'SceneFlicker':
+            # If we strip the prefix, we would get '50Hz', which is illegal name
+            prefix = ''
         else:
             prefix = find_common_prefix([e['name'] for e in enum])
 
-- 
2.34.1



More information about the libcamera-devel mailing list