[libcamera-devel] [PATCH v2 09/19] py: cam: Drop WA_ShowWithoutActivating

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Tue, May 24, 2022 at 02:46:00PM +0300, Tomi Valkeinen wrote:
> Drop WA_ShowWithoutActivating from the Qt renderers. I added the flag
> during development phase as I didn't want the window to take the focus,
> but it should be removed now.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/py/cam/cam_qt.py   | 1 -
>  src/py/cam/cam_qtgl.py | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py
> index 70bdb7bb..03096920 100644
> --- a/src/py/cam/cam_qt.py
> +++ b/src/py/cam/cam_qt.py
> @@ -187,7 +187,6 @@ class QtRenderer:
>          for ctx in self.contexts:
>              for stream in ctx['streams']:
>                  window = MainWindow(ctx, stream)
> -                window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)
>                  window.show()
>                  windows.append(window)
>  
> diff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py
> index 3fb7dde3..c9e367a2 100644
> --- a/src/py/cam/cam_qtgl.py
> +++ b/src/py/cam/cam_qtgl.py
> @@ -137,7 +137,6 @@ class QtRenderer:
>          self.app = QtWidgets.QApplication([])
>  
>          window = MainWindow(self.state)
> -        window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)
>          window.show()
>  
>          self.window = window

-- 
Regards,

Laurent Pinchart