[libcamera-devel] [PATCH 1/3] utils: checkstyle: Run the ClangFormatter last

[Umang Jain]

Hi Laurent,

Thank you for the patch.

On 5/26/22 13:00, Laurent Pinchart via libcamera-devel wrote:
> The IncludeOrderFormatter will be extended with more formatting rules
> that should be applied before clang-format gets run, as it will
> influence its output.
>
> Add a priority mechanism for formatters, and give a negative priority to
> the ClangFormatter to make it run last.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>   utils/checkstyle.py | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index 835f2a9fcd71..66af96abd402 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -279,6 +279,8 @@ class ClassRegistry(type):
>           newclass = super().__new__(cls, clsname, bases, attrs)
>           if bases:
>               bases[0].subclasses.append(newclass)
> +            bases[0].subclasses.sort(key=lambda x: getattr(x, 'priority', 0),
> +                                     reverse=True)


Makes sense..

>           return newclass
>   
>   
> @@ -568,6 +570,7 @@ class Formatter(metaclass=ClassRegistry):
>   
>   class CLangFormatter(Formatter):


Couldn't help with notice the "L" in CLangFormatter, is it intentional. 
Anyways not related to this patch so:

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

>       patterns = ('*.c', '*.cpp', '*.h')
> +    priority = -1
>   
>       @classmethod
>       def format(cls, filename, data):