[libcamera-devel] [PATCH v3 18/30] py: unittests: Fix test_select()

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Fri May 27 16:44:35 CEST 2022


The test_select() current uses self.assertTrue(len(ready_reqs) > 0) to
see that cm.get_ready_requests() returns something. This is not always
the case, as there may be two eventfd events queued, and the first call
to cm.get_ready_requests() returns all the requests, and thus the second
call returns none.

Remove the self.assertTrue(len(ready_reqs) > 0) assert.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
---
 test/py/unittests.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/py/unittests.py b/test/py/unittests.py
index 45b35223..33b35a0a 100755
--- a/test/py/unittests.py
+++ b/test/py/unittests.py
@@ -287,8 +287,6 @@ class SimpleCaptureMethods(CameraTesterBase):
 
                 ready_reqs = cm.get_ready_requests()
 
-                self.assertTrue(len(ready_reqs) > 0)
-
                 reqs += ready_reqs
 
                 if len(reqs) == num_bufs:
-- 
2.34.1



More information about the libcamera-devel mailing list