[libcamera-devel] [PATCH v3 19/30] py: cam: Move conversion funcs to helpers.py

[Tomi Valkeinen]

On 29/05/2022 12:17, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Fri, May 27, 2022 at 05:44:36PM +0300, Tomi Valkeinen wrote:
>> Move conversion functions from cam_qt.py to helpers.py to clean up the
>> code and so that they can be used from other cam renderers.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>> ---
>>   src/py/cam/cam_qt.py                 | 157 +--------------------------
>>   src/py/cam/{cam_qt.py => helpers.py} | 155 +-------------------------
>>   2 files changed, 2 insertions(+), 310 deletions(-)
>>   copy src/py/cam/{cam_qt.py => helpers.py} (55%)
>>
>> diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py
>> index c294c999..af4b0f86 100644
>> --- a/src/py/cam/cam_qt.py
>> +++ b/src/py/cam/cam_qt.py
>> @@ -1,19 +1,15 @@
>>   # SPDX-License-Identifier: GPL-2.0-or-later
>>   # Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>
>> -#
>> -# Debayering code from PiCamera documentation
>>   
>> +from helpers import mfb_to_rgb
>>   from io import BytesIO
>> -from numpy.lib.stride_tricks import as_strided
>>   from PIL import Image
>>   from PIL.ImageQt import ImageQt
>>   from PyQt5 import QtCore, QtGui, QtWidgets
>>   import libcamera as libcam
>>   import libcamera.utils
>> -import numpy as np
>>   import sys
>>   
>> -
> 
> I think pycodestyle would complain about this dropped blank line. Same
> in helpers.py. Apart from that,

No, it doesn't say anything... In any case, fixed.

  Tomi