[libcamera-devel] [PATCH] test: camera_reconfigure: Qualify move() with std:: namespace

[Jacopo Mondi]

Hi Laurent

On Tue, Nov 08, 2022 at 05:27:33PM +0200, Laurent Pinchart via libcamera-devel wrote:
> clang-15 warns about unqualified std cast calls:
>
> ../../test/camera/camera_reconfigure.cpp:101:24: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
>                         requests_.push_back(move(request));
>                                             ^
>                                             std::
>
> Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

I think you can push this!
Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> ---
>  test/camera/camera_reconfigure.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/camera/camera_reconfigure.cpp b/test/camera/camera_reconfigure.cpp
> index d12e2413a4ed..06c87730a130 100644
> --- a/test/camera/camera_reconfigure.cpp
> +++ b/test/camera/camera_reconfigure.cpp
> @@ -98,7 +98,7 @@ private:
>  				return TestFail;
>  			}
>
> -			requests_.push_back(move(request));
> +			requests_.push_back(std::move(request));
>  		}
>
>  		camera_->requestCompleted.connect(this, &CameraReconfigure::requestComplete);
>
> base-commit: aa7b374054c72fbde584f8afb1cc2886a46a57e1
> prerequisite-patch-id: d2f0a36d1e641f882fa4f4910d4bdcf9ea661deb
> --
> Regards,
>
> Laurent Pinchart
>