[libcamera-devel] [PATCH v5 0/7] Raspberry Pi AGC digital gain fixes
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Nov 8 18:22:20 CET 2022
Quoting Laurent Pinchart via libcamera-devel (2022-11-08 16:55:48)
> Hi Naush,
>
> On Tue, Nov 08, 2022 at 09:39:05AM +0000, Naushir Patuck via libcamera-devel wrote:
> > Hi all,
> >
> > Any chance we could progress this one please. Patches 3/4/6 need a second
> > review.
>
> I'm catching up on patch review after my vacation, this is on my list.
> The list is long though :-S
>
> > PS: patchwork.libcamera.org seems to be a bit unhappy for a few days now.
> > Might need a reboot!
> >
Argh ... rebooting!
--
Kieran
> >
> > On Mon, 31 Oct 2022 at 11:45, Naushir Patuck <naush at raspberrypi.com> wrote:
> >
> > > Hi,
> > >
> > > In version 7:
> > >
> > > - For patch 2/7, the cookie must be provided in push() and reset().
> > > Updated the
> > > rkisp1 and ipu3 pipeline handlers to provide frame numbers for the cookie
> > > value.
> > > - For patch 3/4, add a test for skipped/dropped frames and cookie handling.
> > > - Updated patch 6/7 to use the request sequence number for the context
> > > index
> > > instead of using a separte sequence counter.
> > >
> > > Thanks,
> > > Naush
> > >
> > > Naushir Patuck (7):
> > > delayed_controls: Template the ControlRingBuffer class
> > > delayed_controls: Add user cookie to DelayedControls
> > > tests: delayed_controls: Add cookie tests
> > > ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
> > > ipa: raspberrypi: Use an array of RPiController::Metadata objects
> > > pipeline: ipa: raspberrypi: Use IPA cookies
> > > ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
> > >
> > > include/libcamera/internal/delayed_controls.h | 21 +--
> > > include/libcamera/ipa/raspberrypi.mojom | 6 +-
> > > src/ipa/raspberrypi/controller/metadata.h | 10 ++
> > > src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +-
> > > src/ipa/raspberrypi/raspberrypi.cpp | 104 +++++++++------
> > > src/libcamera/delayed_controls.cpp | 22 ++--
> > > src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +-
> > > .../pipeline/raspberrypi/raspberrypi.cpp | 18 ++-
> > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +-
> > > test/delayed_controls.cpp | 121 ++++++++++++++++--
> > > 10 files changed, 240 insertions(+), 88 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
More information about the libcamera-devel
mailing list