[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce zero sequence warning log level

[Umang Jain]

Hi Kieran,

Thank you for the patch

On 10/17/22 2:06 PM, Kieran Bingham via libcamera-devel wrote:
> The V4L2VideoDevice ensures that all sequence numbers for applications
> commence at zero from the libcamera perspective. This should be the
> behaviour expected by kernel drivers, but this is not always the case.
>
> This is handled internally to ensure consistency, and a warning is
> printed if the device does not start from zero. It was expected that the
> Warning would help highlight where kernel drivers should be fixed, but
> this has led to several false positive reports of failures where people
> have been concerned that this warning is a cause for unrelated issues.
>
> Lower the log level print to 'Info', to reduce the apparent severity of
> this warning. Info is likely more appropriate that Debug to continue to
> facilitate awareness of kernel drivers that could be improved, while not
> appearing to be a fault.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/libcamera/v4l2_videodevice.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
> index e30858c9fa02..c2cb9dbfe09c 100644
> --- a/src/libcamera/v4l2_videodevice.cpp
> +++ b/src/libcamera/v4l2_videodevice.cpp
> @@ -1814,7 +1814,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()
>   	 */
>   	if (!firstFrame_) {
>   		if (buf.sequence)
> -			LOG(V4L2, Warning)
> +			LOG(V4L2, Info)
>   				<< "Zero sequence expected for first frame (got "
>   				<< buf.sequence << ")";
>   		firstFrame_ = buf.sequence;