[libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV9281 sensor properties

[Dave Stevenson]

Hi Kieran

On Fri, 11 Nov 2022 at 16:37, Kieran Bingham via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> Add an entry to the sensor properties for the OmniVision OV9281. Test
> patterns are not enabled yet as the driver is not in an upstream kernel.

It's not going to be merged to an upstream kernel.
OV9282 (which is upstream) is the same as OV9281 except for the CRA in
the optical path.
I've sent patches to make ov9282 work with libcamera ([1] and [2]),
and the Pi kernel is hopefully going to drop our downstream ov9281
driver [3] once the patches are accepted by Sakari.

It does leave the odd subject that Alexander started with regard
adopting the compatible name rather than module name for the sensor
[4], and that seems to have gone a bit quiet.

Can I ask what the fascination is with test patterns? Are they really
that useful for drivers that have been merged to mainline and
therefore really should work?

Cheers
  Dave

[1] https://patchwork.linuxtv.org/project/linux-media/cover/20221005152018.3783890-1-dave.stevenson@raspberrypi.com/
[2] https://patchwork.linuxtv.org/project/linux-media/cover/20221028160902.2696973-1-dave.stevenson@raspberrypi.com/
[3] https://github.com/raspberrypi/linux/pull/5187
[4] https://patchwork.linuxtv.org/project/linux-media/patch/20220728130237.3396663-7-alexander.stein@ew.tq-group.com/

> Unit cell size obtained from [0].
>
> [0] https://www.ovt.com/wp-content/uploads/2022/01/OV9281-OV9282-PB-v1.3-WEB.pdf
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/libcamera/camera_sensor_properties.cpp | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index e5f27f06eb1d..3a6682f37707 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -160,6 +160,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                                  */
>                         },
>                 } },
> +               { "ov9281", {
> +                       .unitCellSize = { 3000, 3000 },
> +                       .testPatternModes = {
> +                               { controls::draft::TestPatternModeOff, 0 },
> +                       },
> +               } },
>                 { "ov13858", {
>                         .unitCellSize = { 1120, 1120 },
>                         .testPatternModes =  {
> --
> 2.34.1
>