[libcamera-devel] [PATCH v2] kms: flag 'request' as 'maybe_unused' to avoid 'unused-parameter' warnings

[Laurent Pinchart]

Hi Christian,

Thank you for the patch.

On Fri, Nov 18, 2022 at 09:39:51PM +0100, Christian Rauch via libcamera-devel wrote:
> The parameter 'request' is only used in an assert. assert is only defined
> for debug builds and release builds will not use the parameter, resulting
> in warnings messages only for non-debug builds.
> Fix this by flagging the parameter as 'maybe_unused'.
> 
> Signed-off-by: Christian Rauch <Rauch.Christian at gmx.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/apps/cam/kms_sink.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp
> index 754b061e..353209cd 100644
> --- a/src/apps/cam/kms_sink.cpp
> +++ b/src/apps/cam/kms_sink.cpp
> @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest)
>  	return false;
>  }
> 
> -void KMSSink::requestComplete(DRM::AtomicRequest *request)
> +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request)
>  {
>  	std::lock_guard<std::mutex> lock(lock_);
> 

-- 
Regards,

Laurent Pinchart