[libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain fixes

[Naushir Patuck]

Hi,

Would I be able to get another review on this series please?

Thanks,
Naush


On Tue, 15 Nov 2022 at 09:07, Naushir Patuck <naush at raspberrypi.com> wrote:

> Hi,
>
> Version 6 of this series forks DelayedControls into the Raspberry Pi
> pipeline
> handler namespace, patches 1 and 2 cover this.  Patches 3 and 4 update the
> forked DelayedControls class to add the user cookie with the same set of
> changes
> as were in DelayedControls in version 5 of this series.  I've removed all
> the
> existing review tags from these two patches to give folks another chance to
> validate the changes.
>
> Thanks,
> Naush
>
> Naushir Patuck (8):
>   pipeline: raspberrypi: Fork DelayedControls
>   pipeline: raspberrypi: Switch to RPi::DelayedControls
>   pipeline: raspberrypi: delayed_controls: Template the
>     ControlRingBuffer class
>   pipeline: raspberrypi: delayed_controls: Add user cookie to
>     DelayedControls
>   ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
>   ipa: raspberrypi: Use an array of RPiController::Metadata objects
>   pipeline: ipa: raspberrypi: Use IPA cookies
>   ipa: raspberrypi: agc: Fix digital gain calculation for manual mode
>
>  include/libcamera/ipa/raspberrypi.mojom       |   6 +-
>  src/ipa/raspberrypi/controller/metadata.h     |  10 +
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    |  10 +-
>  src/ipa/raspberrypi/raspberrypi.cpp           | 104 ++++---
>  .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++
>  .../pipeline/raspberrypi/delayed_controls.h   |  87 ++++++
>  .../pipeline/raspberrypi/meson.build          |   1 +
>  .../pipeline/raspberrypi/raspberrypi.cpp      |  26 +-
>  8 files changed, 481 insertions(+), 56 deletions(-)
>  create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp
>  create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h
>
> --
> 2.25.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20221121/fedc6074/attachment.htm>