[libcamera-devel] [PATCH v2 0/5] Resolve invalid attempts to set sensor flip controls

[David Plowman]

Hi again

In v2 of this set, the first 3 patches are unchanged, so thanks for
some of the reviews there.

In the light of the various discussions, I've updated the changes to
those other PHs (uvcvideo, simple and rkisp1). In all cases I'm being
more explicit that I want to preserve the previous behaviour before
this patch set was introduced. This may or may not (probably may not)
be the actual correct behaviour that people would want. So:

uvcvideo: I've deleted the patch that updated this. These are
unaffected by CameraSensor changes so I think I'm better off just
leaving them alone.

simple and rkisp1: Both of these, AIUI, use the CameraSensor class so
previously the flips were getting cleared. Therefore I've added
exactly this into the PHs so that the behaviour is unchanged.

As we had discussed, I think there are concerns that the simple and
rkisp1 PHs implement incorrect behaviours in at least some respects,
but I think it's probably a separate job for someone working on those
platforms to investigate.

Does that make sense?

Thanks!

David

David Plowman (5):
  libcamera: bayer_format: Add toMbusCode method
  libcamera: camera_sensor: Do not clear camera flips when listing
    formats
  libcamera: v4l2_device: Add setTransform method to set a device's flip
    controls
  libcamera: pipeline: simple: Set device's flip controls as previously
  libcamera: pipeline: rkisp1: Set device's flip controls as previously

 include/libcamera/internal/bayer_format.h |  1 +
 include/libcamera/internal/v4l2_device.h  |  3 ++
 src/libcamera/bayer_format.cpp            | 11 +++++
 src/libcamera/camera_sensor.cpp           | 49 ++++++++++++++++++-----
 src/libcamera/pipeline/rkisp1/rkisp1.cpp  |  3 ++
 src/libcamera/pipeline/simple/simple.cpp  |  3 ++
 src/libcamera/v4l2_device.cpp             | 37 +++++++++++++++++
 7 files changed, 97 insertions(+), 10 deletions(-)

-- 
2.30.2