[libcamera-devel] [PATCH 2/2] libcamera: camera_sensor: Add AR0521 sensor properties

[Kieran Bingham]

Quoting Jacopo Mondi via libcamera-devel (2022-11-07 13:22:13)
> Add an entry to the sensor properties for OnSemi AR0521.
> 
> The chip manual list one additional test pattern "PN9 Link integrity
> test pattern" not supported by the mainline Linux driver.
> 
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

I'm curious what applications actually do with the unitCellSize
property, other than just 'know' it ... and whether if it's just about
'knowing' ... maybe other common properties should be reported too. Like
the sensor size/diameter or  maximum resolution.

Anyway, - this is fine ;-)

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index e5f27f06eb1d..d4ee869bf20b 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -52,6 +52,15 @@ LOG_DEFINE_CATEGORY(CameraSensorProperties)
>  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sensor)
>  {
>         static const std::map<std::string, const CameraSensorProperties> sensorProps = {
> +               { "ar0521", {
> +                       .unitCellSize = { 2200, 2200 },
> +                       .testPatternModes = {
> +                               { controls::draft::TestPatternModeOff, 0 },
> +                               { controls::draft::TestPatternModeSolidColor, 1 },
> +                               { controls::draft::TestPatternModeColorBars, 2 },
> +                               { controls::draft::TestPatternModeColorBarsFadeToGray, 3 },
> +                       },
> +               } },
>                 { "hi846", {
>                         .unitCellSize = { 1120, 1120 },
>                         .testPatternModes = {
> -- 
> 2.38.1
>