[libcamera-devel] [PATCH 5/6] utils: libtuning: parsers: raspberrypi: Ignore the plot config parameter

Paul Elder paul.elder at ideasonboard.com
Thu Nov 24 12:38:48 CET 2022


Ignore the plot config parameter that is used in the Raspberry Pi CTT
tuning configuration file, as it conflicts with the debug parameter that
will be provided in the command line arguments.

Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
---
 utils/tuning/libtuning/parsers/raspberrypi_parser.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/utils/tuning/libtuning/parsers/raspberrypi_parser.py b/utils/tuning/libtuning/parsers/raspberrypi_parser.py
index d26586ba..dab50440 100644
--- a/utils/tuning/libtuning/parsers/raspberrypi_parser.py
+++ b/utils/tuning/libtuning/parsers/raspberrypi_parser.py
@@ -54,13 +54,9 @@ class RaspberryPiParser(Parser):
         config.pop('disable')
 
         # The raspberrypi config format has 'plot' map to a list of module
-        # names which should be plotted. libtuning has each module contain the
-        # plot information in itself so do this conversion.
-
-        for module in self._enumerate_rpi_modules(config['plot'], config, modules):
-            # It's fine to set the value of a potentially disabled module, as
-            # the object still exists at this point
-            module.appendValue('debug', 'plot')
+        # names which should be plotted. In libtuning, this information is
+        # passed by command line arguments, so simply drop this piece of
+        # information.
         config.pop('plot')
 
         # Convert the keys from module name to module instance
-- 
2.35.1



More information about the libcamera-devel mailing list