[libcamera-devel] [PATCH] ipa: rkisp1: Add additional default values to controls

[Kieran Bingham]

Quoting Robert Mader via libcamera-devel (2022-11-25 15:48:43)
> To make things easier for consumers.
> 
> Related: https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1450
> 

I think these controls should be managed by the algorithms themselves
... but that's not for this patch, and I think this is reasonable.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Robert Mader <robert.mader at collabora.com>
> ---
>  src/ipa/rkisp1/rkisp1.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 52dffc09..6544c925 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -101,9 +101,9 @@ const ControlInfoMap::Map rkisp1Controls{
>         { &controls::AeEnable, ControlInfo(false, true) },
>         { &controls::AwbEnable, ControlInfo(false, true) },
>         { &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },
> -       { &controls::Brightness, ControlInfo(-1.0f, 0.993f) },
> -       { &controls::Contrast, ControlInfo(0.0f, 1.993f) },
> -       { &controls::Saturation, ControlInfo(0.0f, 1.993f) },
> +       { &controls::Brightness, ControlInfo(-1.0f, 0.993f, 0.0f) },
> +       { &controls::Contrast, ControlInfo(0.0f, 1.993f, 1.0f) },
> +       { &controls::Saturation, ControlInfo(0.0f, 1.993f, 1.0f) },
>         { &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },
>         { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },
>  };
> -- 
> 2.38.1
>