[libcamera-devel] [PATCH 2/8] ipa: camera_sensor_helper: Make registerType() and createInstance() private

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Oct 3 23:21:22 CEST 2022


The CameraSensorHelperFactory registerType() and createInstance()
functions are called by the CameraSensorHelperFactory class only. Make
them private.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
index 2042847f29e8..410156efb2ea 100644
--- a/src/ipa/libipa/camera_sensor_helper.h
+++ b/src/ipa/libipa/camera_sensor_helper.h
@@ -66,15 +66,15 @@ public:
 
 	static std::unique_ptr<CameraSensorHelper> create(const std::string &name);
 
-	static void registerType(CameraSensorHelperFactory *factory);
 	static std::vector<CameraSensorHelperFactory *> &factories();
 
-protected:
-	virtual CameraSensorHelper *createInstance() const = 0;
-
 private:
 	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactory)
 
+	static void registerType(CameraSensorHelperFactory *factory);
+
+	virtual CameraSensorHelper *createInstance() const = 0;
+
 	std::string name_;
 };
 
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list