[libcamera-devel] [PATCH 05/14] libcamera: converter: Add queueBuffer() helper
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Oct 4 00:10:37 CEST 2022
On Wed, Sep 14, 2022 at 12:52:07PM +0200, Jacopo Mondi via libcamera-devel wrote:
> We usually don't allow commits without a message, even more in this
> case where it would be good explain why the helper is, well, helpful
> :)
I can't disagree :-)
> On Thu, Sep 08, 2022 at 08:48:41PM +0200, Xavier Roumegue via libcamera-devel wrote:
> > Signed-off-by: Xavier Roumegue <xavier.roumegue at oss.nxp.com>
> > ---
> > include/libcamera/internal/converter.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h
> > index e2237c57..ea1deab0 100644
> > --- a/include/libcamera/internal/converter.h
> > +++ b/include/libcamera/internal/converter.h
> > @@ -55,6 +55,12 @@ public:
> > virtual int queueBuffers(FrameBuffer *input,
> > const std::map<unsigned int, FrameBuffer *> &outputs) = 0;
> >
> > + int queueBuffer(FrameBuffer *input, FrameBuffer *output)
>
> Does it need documentation ?
Patch 04/14 also requires documentation, I think Xavier wanted a first
review of the overall API in order to avoid spending time writing
documentation that would then need to be rewritten. I assume
documentation will come in v2 or v3.
> > + {
> > + std::map<unsigned int, FrameBuffer *> _output = { { 0, output } };
> > + return queueBuffers(input, _output);
> > + }
> > +
> > std::string deviceNode_;
> > Signal<FrameBuffer *> inputBufferReady;
> > Signal<FrameBuffer *> outputBufferReady;
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list