[libcamera-devel] [PATCH v1 5/9] ipa: raspberrypi: Add pixel clock rate to the CameraMode structure

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Oct 4 19:06:22 CEST 2022


Hi Naush,

Thank you for the patch.

On Mon, Oct 03, 2022 at 09:39:31AM +0100, Naushir Patuck via libcamera-devel wrote:
> The pixel clock rate will be used in subsequent commits to calculate line
> length durations.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/camera_mode.h | 2 ++
>  src/ipa/raspberrypi/raspberrypi.cpp          | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/src/ipa/raspberrypi/controller/camera_mode.h b/src/ipa/raspberrypi/controller/camera_mode.h
> index cda6ac4e200a..b8dae386aee8 100644
> --- a/src/ipa/raspberrypi/controller/camera_mode.h
> +++ b/src/ipa/raspberrypi/controller/camera_mode.h
> @@ -39,4 +39,6 @@ struct CameraMode {
>  	uint32_t minFrameLength, maxFrameLength;
>  	/* sensitivity of this mode */
>  	double sensitivity;
> +	/* pixel clock rate */
> +	uint64_t pixelRate;
>  };
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 9b0ad4361c97..b6289f151677 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -331,6 +331,7 @@ void IPARPi::setMode(const IPACameraSensorInfo &sensorInfo)
>  	mode_.sensorHeight = sensorInfo.activeAreaSize.height;
>  	mode_.cropX = sensorInfo.analogCrop.x;
>  	mode_.cropY = sensorInfo.analogCrop.y;
> +	mode_.pixelRate = sensorInfo.pixelRate;
>  
>  	/*
>  	 * Calculate scaling parameters. The scale_[xy] factors are determined

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list