[libcamera-devel] Build breakage

[Laurent Pinchart]

Hi Naush,

On Wed, Oct 05, 2022 at 10:22:37AM +0100, Naushir Patuck via libcamera-devel wrote:
> Hi,
> 
> Unfortunately It seems the following commit has broken my builds:
> 
> commit 036d26d6677e0b8e6cf284c0801b267c5f81720e
> Author: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Date:   Tue Oct 4 02:42:28 2022 +0300
> 
>     test: threads: Test thread cleanup upon abnormal termination
> 
>     If a thread ends abnormally (that is, without retuning normally from its
>     run() function, for instance with a direct call to pthread_cancel()),
>     thread cleanup should still be performed. Add a test to ensure this.
> 
>     Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>     Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> 
> See the below error message:
> 
> pi at pi4-naush:~/libcamera/build $ ninja
> [2/6] Linking target test/threads
> FAILED: test/threads
> c++  -o test/threads test/threads.p/threads.cpp.o -Wl,--as-needed
> -Wl,--no-undefined -Wno-psabi -Wshadow -include /home/pi/libcamera/build_debug/
> config.h '-Wl,-rpath,$ORIGIN/../src/libcamera:$ORIGIN/../src/libcamera/base'
> -Wl,-rpath-link,/home/pi/libcamera/build_debug/src/libcamera -Wl,-rpath-link,/
> home/pi/libcamera/build_debug/src/libcamera/base -Wl,--start-group test/libtest
> /liblibtest.a src/libcamera/libcamera.so.0.0.0 src/libcamera/base/
> libcamera-base.so.0.0.0 -Wl,--end-group
> /usr/bin/ld: test/threads.p/threads.cpp.o: undefined reference to symbol
> 'pthread_cancel@@GLIBC_2.4'
> /usr/bin/ld: /lib/arm-linux-gnueabihf/libpthread.so.0: error adding symbols:
> DSO missing from command line
> collect2: error: ld returned 1 exit status
> [6/6] Linking target test/fence
> ninja: build stopped: subcommand failed.
> 
> I'm using the following compiler:
> 
> g++ (Raspbian 10.2.1-6+rpi1) 10.2.1 20210110
> Copyright (C) 2020 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> Not really investigated further yet, just wanted to report it first.

Sorry about that. I'll fix it now and submit a patch. I'll CC you for
testing, as it works for me :-)

-- 
Regards,

Laurent Pinchart