[libcamera-devel] [PATCH 6/8] libcamera: pipeline_handler: Make registerType() private
Xavier Roumegue (OSS)
xavier.roumegue at oss.nxp.com
Wed Oct 5 13:10:35 CEST 2022
Hi Laurent,
Thanks for the patch.
On 10/3/22 23:21, Laurent Pinchart via libcamera-devel wrote:
> The PipelineHandlerFactory::registerType() function is called by the
> PipelineHandlerFactory class only. Make it private.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> include/libcamera/internal/pipeline_handler.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
> index 46df69dc789a..ebbdf2aa391f 100644
> --- a/include/libcamera/internal/pipeline_handler.h
> +++ b/include/libcamera/internal/pipeline_handler.h
> @@ -108,10 +108,11 @@ public:
>
> const std::string &name() const { return name_; }
>
> - static void registerType(PipelineHandlerFactory *factory);
> static std::vector<PipelineHandlerFactory *> &factories();
>
> private:
> + static void registerType(PipelineHandlerFactory *factory);
> +
> virtual PipelineHandler *createInstance(CameraManager *manager) const = 0;
>
> std::string name_;
Reviewed-by: Xavier Roumegue <xavier.roumegue at oss.nxp.com>
More information about the libcamera-devel
mailing list