[libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with gcc 8.3.0

[Jacopo Mondi]

Hi Rafal

On Mon, Oct 10, 2022 at 12:04:51PM +0300, Rafael Diniz wrote:
> Btw, this was not committed to master yet, right? Last commit I see is 3
> days old.

No it's not, it's still in active review/testing.
That's why I asked if you can give it a go ;)

>
> Rafael
>
> On 10/10/22 11:36, Jacopo Mondi wrote:
> > Hi Laurent
> >
> > On Sun, Oct 09, 2022 at 07:44:38AM +0300, Laurent Pinchart via libcamera-devel wrote:
> > > Hello,
> > >
> > > It is with great sadness that I have to announce the removal of
> > > utils::defopt. This feature causes compilation failures with gcc 8.0.0
> > > to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to
> > > find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS
> > > support until June 2024, making it an important target.
> > >
> > > I'm sure nobody but me will miss utils::defopt, so I'll get over it.
> >
> > I'm sorry :(
> > But happy gcc8.3 gets fixed
> >
> > Rafael, would you be able to test this and provide a tag ?
> >
> > For the series
> > Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> >
> > Thanks
> >    j
> >
> > >
> > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521
> > >
> > > Laurent Pinchart (2):
> > >    ipa: rkisp1: Drop use of utils::defopt
> > >    libcamera: base: utils: Drop defopt
> > >
> > >   include/libcamera/base/utils.h    | 14 --------
> > >   src/ipa/rkisp1/algorithms/dpf.cpp |  6 ++--
> > >   src/ipa/rkisp1/algorithms/gsl.cpp |  8 ++---
> > >   src/ipa/rkisp1/algorithms/lsc.cpp |  4 +--
> > >   src/libcamera/base/utils.cpp      | 21 ------------
> > >   test/utils.cpp                    | 53 -------------------------------
> > >   6 files changed, 9 insertions(+), 97 deletions(-)
> > >
> > >
> > > base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402
> > > --
> > > Regards,
> > >
> > > Laurent Pinchart
> > >



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20221010/0a107eca/attachment.sig>