[libcamera-devel] [PATCH v1 4/4] ipa: rkisp1: Downgrade sensor controls range message to Debug

[Jacopo Mondi]

Hi Laurent

On Wed, Oct 19, 2022 at 12:42:35PM +0100, Kieran Bingham via libcamera-devel wrote:
> Quoting Laurent Pinchart via libcamera-devel (2022-10-19 12:04:34)
> > There's no need to print the exposure and gain control ranges as an Info
> > message. Downgrade it to Debug. While at it, print the ranges using the
> > "[min, max]" syntax.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>

Thanks
  j

> > ---
> >  src/ipa/rkisp1/rkisp1.cpp | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> > index bef5211d5c34..7dd340cf50af 100644
> > --- a/src/ipa/rkisp1/rkisp1.cpp
> > +++ b/src/ipa/rkisp1/rkisp1.cpp
> > @@ -232,9 +232,9 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,
> >         int32_t minGain = itGain->second.min().get<int32_t>();
> >         int32_t maxGain = itGain->second.max().get<int32_t>();
> >
> > -       LOG(IPARkISP1, Info)
> > -               << "Exposure: " << minExposure << "-" << maxExposure
> > -               << " Gain: " << minGain << "-" << maxGain;
> > +       LOG(IPARkISP1, Debug)
> > +               << "Exposure: [" << minExposure << ", " << maxExposure
> > +               << "], gain: [" << minGain << ", " << maxGain << "]";
>
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> >
> >         /* Clear the IPA context before the streaming session. */
> >         context_.configuration = {};
> > --
> > Regards,
> >
> > Laurent Pinchart
> >