[libcamera-devel] [PATCH v1 6/6] apps: Shared common source between applications

[paul.elder at ideasonboard.com]

On Thu, Oct 20, 2022 at 02:15:37AM +0300, Laurent Pinchart via libcamera-devel wrote:
> Multiple source files in the src/apps/cam/ directory are used by cam,
> qcam and lc-compliance. They are compiled separately for each
> application. Move them to the src/apps/ directory and compile them in a
> static library to decrease the number of compilation operations.

In the subject, s/Shared/Share/

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/apps/cam/camera_session.cpp         |  5 +++--
>  src/apps/cam/camera_session.h           |  2 +-
>  src/apps/cam/drm.cpp                    |  2 +-
>  src/apps/cam/file_sink.cpp              |  5 +++--
>  src/apps/cam/main.cpp                   |  7 ++++---
>  src/apps/cam/meson.build                | 14 ++------------
>  src/apps/cam/sdl_sink.cpp               |  5 +++--
>  src/apps/cam/sdl_texture.h              |  2 +-
>  src/apps/{cam => }/dng_writer.cpp       |  0
>  src/apps/{cam => }/dng_writer.h         |  0
>  src/apps/{cam => }/event_loop.cpp       |  0
>  src/apps/{cam => }/event_loop.h         |  0
>  src/apps/{cam => }/image.cpp            |  0
>  src/apps/{cam => }/image.h              |  0
>  src/apps/lc-compliance/main.cpp         |  2 +-
>  src/apps/lc-compliance/meson.build      |  3 +--
>  src/apps/lc-compliance/simple_capture.h |  2 +-
>  src/apps/meson.build                    | 25 +++++++++++++++++++++++++
>  src/apps/{cam => }/options.cpp          |  0
>  src/apps/{cam => }/options.h            |  0
>  src/apps/qcam/format_converter.cpp      |  2 +-
>  src/apps/qcam/main.cpp                  |  4 ++--
>  src/apps/qcam/main_window.cpp           |  4 ++--
>  src/apps/qcam/main_window.h             |  2 +-
>  src/apps/qcam/meson.build               | 13 ++-----------
>  src/apps/qcam/viewfinder_gl.cpp         |  2 +-
>  src/apps/qcam/viewfinder_qt.cpp         |  2 +-
>  src/apps/{cam => }/stream_options.cpp   |  0
>  src/apps/{cam => }/stream_options.h     |  0
>  29 files changed, 56 insertions(+), 47 deletions(-)
>  rename src/apps/{cam => }/dng_writer.cpp (100%)
>  rename src/apps/{cam => }/dng_writer.h (100%)
>  rename src/apps/{cam => }/event_loop.cpp (100%)
>  rename src/apps/{cam => }/event_loop.h (100%)
>  rename src/apps/{cam => }/image.cpp (100%)
>  rename src/apps/{cam => }/image.h (100%)
>  rename src/apps/{cam => }/options.cpp (100%)
>  rename src/apps/{cam => }/options.h (100%)
>  rename src/apps/{cam => }/stream_options.cpp (100%)
>  rename src/apps/{cam => }/stream_options.h (100%)

Eeeh I think it would be cleaner with a libapps directory. Otherwise in
src/apps we have apps... and a bunch of loose-ish source files.

<snip>


Paul