[libcamera-devel] [PATCH] libcamera Android Enhancements

[Nicholas Roth]

> They can all be part of one series. Please add the makefiles in the last
patch of the series.
Acknowledged

> Thank you for the patch.
You're welcome!

> I think you meant bug 156.
Correct. Fixed

>I don't lije this much. What other options do we have on Android to
verify signatures ?
We have boringssl, Google's AOSP-compatible OpenSSL fork, which guarantees
neither API nor ABI compatibility. Technically this does work, but
disabling this seems less likely to break and reduces complexity, plus why
not give people the option? I'd like to understand your preference here
better-- why wouldn't we want to let users choose to disable module
isolation?

I'll leave this as the last commit in the chain so we can discuss.
Excluding the option looks like it should still work for the time being, so
that's what the first patches will assume.

> The addition of LOG() calls may need to be further split in multiple
patches
I like my logging messages :-). On a more serious note, I think these are
useful, but I'd like to read your thoughts too. I'll be happy to split
these up further per your comments if that's what you'd like.

> In v2, could you also please send patches inline, not as attachments ? I
> highly recommend usage of git-send-email (with a cover letter) to avoid
> lots of potential issues with various mail clients.
Sounds good-- I'll try this out for v2.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20221023/decf5b54/attachment.htm>