[libcamera-devel] [PATCH 01/11] Fixes Bug 156, which breaks libcamera on Android < 12.
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Oct 24 12:43:38 CEST 2022
Quoting Kieran Bingham (2022-10-24 11:41:12)
> Hi Nicholas,
>
> Thanks for breaking these up - much easier to review, and work out how
> to integrate.
>
> Could I ask you to read https://cbea.ms/git-commit/ please?
>
> That's not written by us, but it's a close summary of how we like to see
> commit messages formed for the project.
>
>
>
> Quoting Nicholas Roth via libcamera-devel (2022-10-24 06:55:33)
> > From: Nicholas Roth <nicholas at rothemail.net>
> >
>
Ooops, I didn't come back up to finish this:
> So for this patch, I would propose a subject line / commit message of:
ipa: workaround libcxx duration limitation
A bug in libcxx used by clang version 11.0.2 is prevalent when building
libcamera for Android SDK30. This has been fixed and integrated upstream
with [0].
As a workaround, directly cast the affected chrono types to prevent
operations of Chrono or Duration being divided.
[0] https://github.com/llvm/llvm-project/commit/efa6d803c624f9251d0ab7881122501bb9d27368
Bug: https://bugs.libcamera.org/show_bug.cgi?id=156
Signed-off-by: Nicholas Roth <nicholas at rothemail.net>
(Adapt, expand, correct the above of course)
--
Kieran
More information about the libcamera-devel
mailing list