[libcamera-devel] [PATCH 01/11] Fixes Bug 156, which breaks libcamera on Android < 12.

[Kieran Bingham]

Quoting Nicholas Roth (2022-10-27 05:24:28)
> >  cp utils/hooks/post-commit .git/hooks/post-commit
> The post-commits seem to want me to replace my tabs with spaces. I use tabs
> to be consistent with the surrounding codebase. Is it OK to ignore these
> errors, or should I do something else?

That's odd - it shouldn't be changing tabs for spaces?

What's your tabsize set to ? We use 8-character tabs.

 
> Example:
> --- src/android/camera_hal_config.cpp
> +++ src/android/camera_hal_config.cpp
> @@ -164,7 +164,7 @@
>         File file(filePath);
>         if (!file.exist()) {
>                 LOG(HALConfig, Debug)
> -                                       << "Configuration file: \"" <<
> filePath << "\" not found";
> +                       << "Configuration file: \"" << filePath << "\" not
> found";
>                 return -ENOENT;

In my terminal, this change looks correct:

		LOG(HALConfig, Debug)
			<< "Configuration file: \"" << filePath << "\" not found";

We often take the debug print lines to the following line to allow a
longer length without breaking the text, or hitting our line length
limit. We only use a single indentation from the start of the previous
line

--
Kieran


>         }
> 
> ---
> 1 potential issue detected, please review