[libcamera-devel] [PATCH v5 0/7] Raspberry Pi AGC digital gain fixes

Naushir Patuck naush at raspberrypi.com
Mon Oct 31 12:45:15 CET 2022


Hi,

In version 7:

- For patch 2/7, the cookie must be provided in push() and reset(). Updated the
rkisp1 and ipu3 pipeline handlers to provide frame numbers for the cookie value.
- For patch 3/4, add a test for skipped/dropped frames and cookie handling.
- Updated patch 6/7 to use the request sequence number for the context index
instead of using a separte sequence counter.

Thanks,
Naush

Naushir Patuck (7):
  delayed_controls: Template the ControlRingBuffer class
  delayed_controls: Add user cookie to DelayedControls
  tests: delayed_controls: Add cookie tests
  ipa: raspberrypi: Add RPiController::Metadata::mergeCopy
  ipa: raspberrypi: Use an array of RPiController::Metadata objects
  pipeline: ipa: raspberrypi: Use IPA cookies
  ipa: raspberrypi: agc: Fix digital gain calculation for manual mode

 include/libcamera/internal/delayed_controls.h |  21 +--
 include/libcamera/ipa/raspberrypi.mojom       |   6 +-
 src/ipa/raspberrypi/controller/metadata.h     |  10 ++
 src/ipa/raspberrypi/controller/rpi/agc.cpp    |  10 +-
 src/ipa/raspberrypi/raspberrypi.cpp           | 104 +++++++++------
 src/libcamera/delayed_controls.cpp            |  22 ++--
 src/libcamera/pipeline/ipu3/ipu3.cpp          |   9 +-
 .../pipeline/raspberrypi/raspberrypi.cpp      |  18 ++-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp      |   7 +-
 test/delayed_controls.cpp                     | 121 ++++++++++++++++--
 10 files changed, 240 insertions(+), 88 deletions(-)

-- 
2.25.1



More information about the libcamera-devel mailing list