[libcamera-devel] [PATCH] meson: disable tests by default

[Laurent Pinchart]

Hi Christian,

Thank you for the patch.

On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:
> Compiling with tests adds a significant amount of build targets to the
> meson build. However, tests are only of interest when a feature has been
> implemented or for continuous integration.
> Disable tests by default to reduce the computational resource requirements
> and the duration of a complete libcamera built.
> 
> Signed-off-by: Christian Rauch <Rauch.Christian at gmx.de>

As most people building libcamera won't run tests, this seems reasonable
to me. I'm however a bit worried that it would lead to lower
compilation-test coverage, as people may send patches without realizing
they break compilation of tests. We already have that problem for
runtime breakages of tests, and it's most likely be addressed by test
automation on patches submitted upstream, so I think I'm fine with the
change.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  meson_options.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index 7a9aecfc..f1d67808 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -47,6 +47,7 @@ option('qcam',
> 
>  option('test',
>          type : 'boolean',
> +        value : false,
>          description: 'Compile and include the tests')
> 
>  option('tracing',

-- 
Regards,

Laurent Pinchart