[libcamera-devel] [PATCH 0/3] libcamera: Fix crash with UVC cameras that expose no supported format

[Christian Rauch]

Hi Laurent,


Am 06.09.22 um 00:31 schrieb Laurent Pinchart:
> Christian,
>
> Would you be able to test that this series fixes the issue you're
> experiencing ? If so, can I add your Tested-by ?

Your patch series works. For "cam" I get:

ERROR UVC uvcvideo.cpp:461 Camera [...] doesn't expose any supported format
Camera 1 not found
Failed to create camera session

However, I found the message "Camera 1 not found" somehow misleading,
since the camera was found, but it just did not expose any supported format.

Can I insert the "Tested-by" just here in the email?

Tested-by: Christian Rauch <Rauch.Christian at gmx.de>

Best,
Christian


> On Sat, Sep 03, 2022 at 09:10:34PM +0300, Laurent Pinchart via libcamera-devel wrote:
>> Hello,
>>
>> This patch series fixes a crash in the uvcvideo pipeline handler with
>> cameras that exposes only formats that are not supported by libcamera.
>> Patches 1/3 and 2/3 perform small refactoring, to prepare for patch 3/3
>> that fixes the crash by rejecting those cameras.
>>
>> Laurent Pinchart (3):
>>   pipeline: uvcvideo: Move camera ID generation to UVCCameraData class
>>   pipeline: uvcvideo: Cache supported formats in UVCCameraData
>>   pipeline: uvcvideo: Fail match() if the camera has no supported format
>>
>>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 200 ++++++++++---------
>>  1 file changed, 107 insertions(+), 93 deletions(-)
>>
>>
>> base-commit: 251f0534b74bcb46c777aa0df34b1b4142b664f5
>